Fix comment for OTEL env var reading condition#200
Merged
Conversation
purple4reina
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix comment for OTEL env var reading condition.
Motivation
While reading the code to check the configuration values of datadog-lambda-go, I noticed that the comment and the implementation are incorrect.
Testing Guidelines
Code reading (because this PR only changes the comment).
When reading the
HandlerStartedfunction, I noticed that ifl.ddTraceEnabledis false, the function returns early, while if it is true, the process continues and further actions are taken depending on the condition ofl.otelTracerEnabled. In other words, when Datadog Trace is enabled, OpenTelemetry Trace is also enabled. This shows that the comment is incorrect and the implementation is correct.Additional Notes
The comment was inserted by:
Types of changes
Checklist